We Keep Coding

Comparing a string to a user input - Class issue?

Okay so i'm having issues with comparing a user inputted value with that already printed into the command line.
The printing to the command line is controlled by the classes that are called and i believe that it's causing issues with the process!
fairly sure i need to use def but i'm new to all of this so i don't know where to start!
Thanks for any help ahead of time! Not sure if this is the best way to go about creating a card game as it's pretty convoluted let me know your thoughts!
Originally tried to convert the hand of cards (bob.showHand) into a string but because it's being generated by a class it doesnt work? It's not much code so i've dumped it all below hope that's fine!
print('Running')
import random
class Turn:
def __init__(self, start):
self.start = start
class Card:
def __init__(self, suit, val):
self.suit = suit
self.value = val
def show(self):
print('{} of {}'.format(self.value, self.suit))
class Deck:
def __init__(self):
self.cards = []
self.build()
def build(self):
for s in ['Spades', 'Clubs', 'Diamonds', 'Hearts']:
for v in range(1,14):
self.cards.append(Card(s, v))
def show(self):
for c in self.cards:
c.show()
def shuffle(self):
for i in range(len(self.cards) - 1, 0, -1):
r = random.randint(0, i)
self.cards[i], self.cards[r] = self.cards[r], self.cards[i]
def drawCard(self):
return self.cards.pop()
def draw(self, deck):
self.hand.append(deck,drawCard())
return self
class Player1:
def __init__(self, name):
self.name = name
self.hand = []
def draw(self, deck):
self.hand.append(deck.drawCard())
return self
def showHand(self):
for card in self.hand:
card.show()
class Player2:
def __init__(self, name):
self.name = name
self.hand = []
def draw(self, deck):
self.hand.append(deck.drawCard())
return self
def showHand(self):
for card in self.hand:
card.show()
print('generating deck')
deck = Deck()
print('shuffling deck')
deck.shuffle()
bob = Player1('bob')
ryan = Player2('ryan')
print('dealing deck')
for x in range(7):
bob.draw(deck)
for y in range(7):
ryan.draw(deck)
Turn.start = 0
if Turn.start == 0:
print('bob to act')
print("bob's hand below")
print(bob.showHand())
cardplay = input('Type the card to play it')
if cardplay == bob.showHand():
print('playing card!')
I'd expect the print of playing card to appear. However no matter how much i try i can't seem to get it too work!

Your showHand method does not create a string; it causes print to be used to display text in the terminal. input reads a string from the user, and stores it. The == comparison will never compare equal, because on one side you have a string, and on the other side you have the special value None.
You should not have the methods of any of your classes do any print calls. Instead, have them return the appropriate strings, which are then printed from outside.
Also, by using a special name for these methods - __str__ - we can make Python use it automatically when printing a class instance, or when converting to string using str. Consider the example:
class Card:
def __init__(self, suit, val):
self.suit = suit
self.value = val
def __str__(self):
return f'{self.value} of {self.suit}'
class Hand:
def __init__(self, cards):
self.cards = cards
def __str__(self):
return ' | '.join(str(card) for card in self.cards)
my_hand = Hand([Card('Spades', 'Ace'), Card('Diamonds', 'King')]) # blackjack!
print(my_hand) # we see: `Ace of Spades | King of Diamonds`

Your problem is that if cardplay == bob.showHand(): does not actually do what you think. showHand() returns None and that will never equal any input Card. You need to convert what the user inputs to a card and then compare that card to the cards the Player is currently holding.
To solve these issues and make your code do what you are trying to do, change your Card Class to the following:
class Card:
def __init__(self, suit, val):
self.suit = suit
self.value = val
def show(self):
print('{} of {}'.format(self.value, self.suit))
def __eq__(self, other):
if (other.suit == self.suit and other.value == self.value):
return True
else:
return False
and the last couple of lines to this:
Turn.start = 0
if Turn.start == 0:
print('bob to act')
print("bob's hand below")
bob.showHand()
cardplay = input('Type the card to play it')
picked = Card(cardplay.split()[2], int(cardplay.split()[0]))
for card in bob.hand:
if picked == card:
print('playing card!')
Then, you can enter any Card, exactly as it appears, on the input line and it will print
'playing card!'

class inheritance exercise using Old Maid card game as example

I am currently learning about class inheritance in python. In the example below, the goal is to remove card pairs(any 2 cards with the same value and color, e.g 3 of hearts and 3 of diamonds) in a single hand containing 13 distinct, random cards.
It seems the error is at line 127: if match in self.cards: . This statement always returns true even if match is not in self.cards . The error is ValueError: list.remove(x): x not in list. Anyone has any idea how to achieve the intended goal? Thanks.
p.s learning through: How to Think Like a Computer Scientist.
class Card:
"""represents a card found in a standard deck with 52 cards."""
suits = ["Clubs", "Diamonds", "Hearts", "Spades"]
ranks = ["narf", "Ace", "2", "3", "4", "5", "6", "7",
"8", "9", "10", "Jack", "Queen", "King"]
def __init__(self, suit=0, rank=0):
self.suit = suit
self.rank = rank
def __str__(self):
return (self.ranks[self.rank] + ' of ' + self.suits[self.suit])
def cmp(self, other):
if self.suit > other.suit:
return 1
if self.suit < other.suit:
return -1
if self.rank < other.rank:
return 1
if self.rank < other.rank:
return -1
return 0
def __eq__(self, other):
return self.cmp(other) == 0
def __le__(self, other):
return self.cmp(other) <= 0
def __lt__(self, other):
return self.cmp(other) < 0
def __ge__(self, other):
return self.cmp(other) >= 0
def __gt__(self, other):
return self.cmp(other) > 0
def __ne__(self, other):
return self.cmp(other) != 0
class Deck:
"""Contains a list of cards as attribute and generates the 52 cards"""
def __init__(self):
self.cards = []
for suit in range(4):
for rank in range(1, 14):
self.cards.append(Card(suit, rank))
def __str__(self):
s = ""
for i in range(len(self.cards)):
s = s + " " * i + str(self.cards[i]) + "\n"
return s
def print_deck(self):
for card in self.cards:
print(card)
def shuffle(self):
"""shuffles the deck of cards randomly."""
import random
rng = random.Random()
rng.shuffle(self.cards)
def remove(self, card):
"""Removes a single specified card from the deck."""
if card in self.cards:
self.cards.remove(card)
return True
else:
return False
def pop(self):
"""Select a single card from the deck"""
return self.cards.pop()
def is_empty(self):
if self.cards == []:
return True
return False
def deal(self, hands, num_cards=52):
"""Deals cards from the deck to a list of hands.
If number of card to deal is not specified, the entire deck is dealt."""
for i in range(num_cards):
if self.cards == []:
break
card = self.pop()
hand = hands[i % len(hands)]
hand.add(card)
class Hand(Deck):
def __init__(self, name=''):
Deck.__init__(self)
self.cards = []
self.name = name
def __str__(self):
string = "The Hand " + self.name
if self.is_empty():
string += 'is empty.\n'
else:
string += ' contains:\n'
return string + Deck.__str__(self)
def add(self, card):
self.cards.append(card)
class CardGame:
def __init__(self):
self.deck = Deck()
self.deck.shuffle()
class OldMaidHand(Hand):
"""Creates a hand for a single player to play a game of Old Maid."""
def remove_matches(self):
cards = self.cards[:]
for card in cards:
match = Card(3 - card.suit, card.rank)
if match in self.cards:
self.cards.remove(card)
self.cards.remove(match)
print('Hand {0} removed {1} and {2}.'
.format(self.name, card, match))
game = CardGame()
player1 = OldMaidHand('test')
game.deck.deal([player1], 13)
player1.print_deck()
player1.remove_matches()

how to use a variable from one class in another class without passing the class as an argument in the constructor

I want to use self.numbers and self.suits from the Cards class in the Deck class. The only way i know to do this is what is shown below. Pass class.card as an argument in the class Deck's __init__ method. Here is the problem. In order to then use the Deck class, I have to pass an argument as well and i do not need or want to do that. Hopefully, I'm explaining myself well. I have the same problem trying to pass variables from the Card class and the Deck class in the Player class.
Here is the code:
import random
class Card:
def __init__(self):
self.numbers = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 'jack', 'queen', 'king', 'ace']
self.suits = ['hearts', 'diamonds', 'clubs', 'spades']
# print the current card
def __str__(self):
print(f'{self.numbers} of {self.suits}')
class Deck(Card):
def __init__(self, class_card):
super().__init__()
self.deck = []
self.numbers = class_card.numbers
self.suits = class_card.suits
# create a new deck of cards
def create_deck(self):
for suit in self.suits:
for number in self.numbers:
self.deck.append([number, suit])
return self.deck
# shuffle the deck of cards before the start of the game
def shuffle_deck(self, deck):
random.shuffle(deck)
class Player(Deck):
def __init__(self, class_deck):
super().__init__()
self.hand = []
self.count_cards = 0
self.score = 0
# draw a card from the deck
def draw_card(self):
drawn_card = self.hand.append(self.deck[-1])
return drawn_card
# count the cards in the players hand
def count_hand(self):
self.count_cards = len(self.deck)
return self.count_cards
# calculate the score each time the player wins
def calculate_score(self):
pass

When you run super().__init__() the deck will inherit the numbers and suits attribute from card. See the follows:
import random
class Card:
def __init__(self):
self.numbers = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 'jack', 'queen', 'king', 'ace']
self.suits = ['hearts', 'diamonds', 'clubs', 'spades']
# print the current card
def __str__(self):
print(f'{self.numbers} of {self.suits}')
class Deck(Card):
def __init__(self):
super().__init__()
self.deck = []
# create a new deck of cards
def create_deck(self):
for suit in self.suits:
for number in self.numbers:
self.deck.append([number, suit])
return self
# shuffle the deck of cards before the start of the game
def shuffle_deck(self):
random.shuffle(self.deck)
def __len__(self):
return len(self.deck)
def pop(self):
return self.deck.pop()
class People:
def __init__(self, name):
self.name = name
class Player(People):
def __init__(self, name, deck):
super().__init__(name)
self.hand = []
self.count_cards = 0
self.score = 0
self.deck = deck
# draw a card from the deck
def draw_card(self):
drawn_card = self.hand.append(self.deck.pop())
return drawn_card
# count the cards in the players hand
def count_hand(self):
self.count_cards = len(self.hand)
return self.count_cards
# calculate the score each time the player wins
def calculate_score(self):
pass
def main():
deck = Deck().create_deck()
players = [Player(name, deck) for name in ('Jim', 'Ben', 'Paul', 'Wang')]
deck.shuffle_deck()
i = 0
while len(deck):
players[i].draw_card()
i = (i + 1) % len(players)
for p in players:
print(p.name, p.count_hand(), p.calculate_score())
if __name__ == '__main__':
main()
Output:
Jim 14 None
Ben 14 None
Paul 14 None
Wang 14 None
However, my recommend solution is like this:
import random
class Card:
numbers = [2, 3, 4, 5, 6, 7, 8, 9, 10, 'jack', 'queen', 'king', 'ace']
suits = ['hearts', 'diamonds', 'clubs', 'spades']
def __init__(self, number, suit):
self.number = number
self.suit = suit
self.score = self.numbers.index(number) * 10 + self.suits.index(suit)
# print the current card
def __str__(self):
print(f'{self.number} of {self.suit}')
def __eq__(self, other):
return self.score == other.score
def __lt__(self, other):
return self.score < other.score
class Deck:
def __init__(self):
self.deck = [
Card(num, suit) for num in Card.numbers for suit in Card.suits
]
# shuffle the deck of cards before the start of the game
def shuffle(self):
random.shuffle(self.deck)
return self
def __len__(self):
return len(self.deck)
def pop(self):
return self.deck.pop()
class People:
def __init__(self, name):
self.name = name
class Player(People):
def __init__(self, name, deck):
super().__init__(name)
self.hand = []
self.count_cards = 0
self.score = 0
self.deck = deck
# draw a card from the deck
def draw_card(self):
drawn_card = self.hand.append(self.deck.pop())
return drawn_card
# count the cards in the players hand
def count_hand(self):
self.count_cards = len(self.hand)
return self.count_cards
# calculate the score each time the player wins
def calculate_score(self):
return sum(card.score for card in self.hand)
def main():
deck = Deck().shuffle()
players = [Player(name, deck) for name in ('Jim', 'Ben', 'Paul', 'Wang')]
i = 0
while len(deck):
players[i].draw_card()
i = (i + 1) % len(players)
for p in players:
print(p.name, p.count_hand(), p.calculate_score())
if __name__ == '__main__':
main()

How to create a hand with 13 playing cards in it

I was given a project in computer science, however I can't figure out how to get 13 cards into my hand. There is a memory error in the hand class, but I can't figure out why, it isn't putting 13 cards in each hand. Here is my code so far:
#Keshav Ramesh
#Project 8
import random
class card:
def __init__(self, suit, value):
self.suit=suit
self.value=value
#methods
def printer(self):
print("{0} {1}".format(self.suit, self.value))
def __lt__(self, other):
if(self.value == other.value):
return self.suit < other.suit
elif (self.value != other.value):
return self.value < other.value
def __gt__(self, other):
return not(self<other)
def __str__(self):
return "Suit: " + str(self.suit) + " value: " + str(self.value)
class deck:
def __init__(self):
self.x=[]
self.load()
random.shuffle(self.x)
def load(self):
for i in range(1, 5):
for j in range(2, 14):
self.x.append(card(i, j))
def deal(self):
return self.x.pop()
p = deck()
class hand:
def __init__(self):
self.x=[]
self.hand_count=0
while len(self.x) != 13:
self.x.append(p.deal())
def accept(self, a):
self.x.append(a)
self.hand_count= self.hand_count + 1
def play(self):
self.hand_count = self.hand_count - 1
return self.x.pop()
def handPrinter(self):
while len(self.x) != 0:
result = (self.pop())
print("{0} {1}".format(result.suit, result.value))

When you do
result = (self.pop())
in the handPrinter method maybe you meant to do
result = (self.x.pop())
That was causing an error when executing your code. Also, in the __init__ method of Card class you should ident self.suit = suit and self.value = value.
Other than that, by adding
h = hand()
h.handPrinter()
at the end, everything seems to be working fine to me.

python Blackjack Graphics Game - my card image won't import

I'm making a Blackjack game and still early process. When I run my program, I get the error
im = Image(Point(350, 250), "playingcards/" + suit + str(rank) + ".gif")
NameError: name 'suit' is not defined
Which I'm pretty sure it's because im = ___ is in my def main(): part of my function, even though the suit is being defined within my code.
It's basically seems like my program is ignoring all of my code and going straight to the def main(), which is probably an ordering error on my part, but can someone explain where it's supposed to go so that it reads all my class functions before the main?
Here's my code:
from random import *
from graphics import *
class PlayingCard:
def __init__(self, rank, suit):
self.rank = rank
self.suit = suit
def getRank (self):
return self.rank
def getSuit(self):
return self.suit
def BJValue (self):
if self.rank == 'Ace':
return 1
elif self.rank == 'Jack' or self.rank == 'Queen' or self.rank == 'King':
return 10
else:
return int(self.rank)
def __str__(self):
suit_name= {'S':'Spades', 'C':'Clubs', 'D':'Diamonds', 'H':'Hearts'}
rank_name=[None, 'Ace','2','3','4','5','6','7','8','9','10','Jack','Queen','King']
return '%s of %s' % (Card.rank_names[self.rank], Card.suit_names[self.suit])
from random import *
from playingcards import *
class Deck:
def __init__(self):
self.cards = []
x = eval(input("How many cards shall be dealt?"))
for suit in range(x):
for rank in range(1, 14):
card = Card(suit, rank)
self.cards.append(card)
def shuffle(self):
random.shuffle(self.cards)
def DealCard(self):
return self.deck.pop(0)
def CardsLeft(self):
return len(self.deck)
class Blackjack:
def __init__(self, dHand=[], pHand=[]):
self.dHand = PlayingCard
self.pHand = PlayingCard
self.deck = Deck()
Deck.shuffle(self.Blackjack)
def initDeal(self,gwin,xposD,yposD,xposP,yposP):
self.DealCard.dHand = [2]
self.DealCard.pHand = [2]
# PlayingCard.draw(win)
dealtCard = self.deck.DealCard()
suit = dealtCard.getSuit()
rank = dealtCard.getRank()
#import(file=image_
def hit(self, gwin, xPos, yPos):
print('hi')
def evaluateHand(self, hand):
print('hi')
def dealerPlays(self, gwin, xPos, yPos):
print('hi')
def main():
win = GraphWin("BlackJack", 800, 800)
im = Image(Point(350, 250), "playingcards/" + suit + str(rank) + ".gif")
im.draw(win)
if __name__ == "__main__":
main()