We Keep Coding

How to include an object from another model in a generic Django CreateView?

Ok so I am trying to include the corrosponding Comment in my createAnswer View currently the url of the createAnswer page includes the pk ok the right comment so i need to get the comment by the id in the url.
My generic CreateView looks like this:
class createAnswer(CreateView):
model = Answer
fields = ['content']
def getComment(self, request):
???
comment = getComment()
def get_success_url(self):
this_path = self.request.get_full_path()
path_list = this_path.split('/')
def get_comment_id(self):
for i in range(len(path_list)):
if path_list[i].isdigit():
return path_list[i]
return '/blogcontact/comment/'+ get_comment_id(self)
def form_valid(self,form):
this_path = self.request.get_full_path()
path_list = this_path.split('/')
def get_comment_id(self):
for i in range(len(path_list)):
if path_list[i].isdigit():
return path_list[i]
form.instance.author = self.request.user
form.instance.comment = Comment.objects.get(id=get_comment_id(self))
return super().form_valid(form)
My Urls.py looks like this:
from django.urls import path
from . import views
from .views import createAnswer
urlpatterns = [
path('contact/comment/<int:pk>/newanswer', createAnswer.as_view(),
name='answer-create')
]<br>
I would like to save the Comment object in a variable so i Can use it in the html template like this {{comment}}

I think you you are confusing the function views and the Class Based Views (CBV), and you never import a request, it is just a parameter your views receive.
In a function view you do the following:
def my_view(request):
if request.method == 'POST':
# do some stuff
For CBV each method is a function:
from django.views.generic.edit import CreateView
class MyView(CreateView):
model = Answer
fields = ['content']
def get(self, request):
# do some stuff
def post(self, request):
# do some stuff
EDIT: To access the url parameters in class based views use self.kwargs, so you would access the comment pk by doing self.kwargs['pk']. Now you just need to get the comment and add it to the context data:
class CreateAnswer(CreateView):
model = Answer
fields = ['content']
def get_context_data(self, **kwargs):
kwargs['comment'] = Comment.objects.get(pk=self.kwargs['pk'])
return super().get_context_data(**kwargs)
def form_valid(self, form):
# do some stuff

Django - Inline formset - storing only the last row of the child model (in 1 to many relationship)

Python :3.6.2 Django : 1.11.4
We are trying to use foreignkey across apps. Address is consumed by both customer and agent. We are also using inline formset. Form showing up correct. Please see below for the picture.
Create Agent Screen
However, when you save it, it saves just the just last of address. Also please note that in edit, a blank line is added which I think should not added by default. Please see below for the pic.
Edit Agent screen
Folder structure
apps (Folder)
agent (app)
models.py
views.py
customer (app)
models.py
views.py
sharedmodels(app)
models.py
forms.py
agent/views.py
from django.shortcuts import render
# Create your views here.
from django.db import transaction
from django.urls import reverse_lazy
from django.views.generic import CreateView, UpdateView, ListView
from apps.agent.models import Agent
from apps.sharedmodels.forms import AgentAddressFormSet
from multiApps.logger import log
class AgentList(ListView):
model = Agent
class AgentCreate(CreateView):
model = Agent
fields = ['first_name']
#log.info(fields)
class AgentAddrLocArefCreate(CreateView):
model = Agent
fields = ['first_name']
success_url = reverse_lazy('agent-list')
def get_context_data(self, **kwargs):
data = super(AgentAddrLocArefCreate, self).get_context_data(**kwargs)
log.info('i m here 1')
if self.request.POST:
log.info('i m here 2')
#data['location'] = LocationFormSet(self.request.POST)
data['address'] = AgentAddressFormSet(self.request.POST)
#data['agentreferal'] = AgentReferalFormSet(self.request.POST)
else:
#data['location'] = LocationFormSet()
data['address'] = AgentAddressFormSet()
#data['agentreferal'] = AgentReferalFormSet()
return data
def form_valid(self, form):
context = self.get_context_data()
#location = context['location']
agentaddress = context['address']
log.info('i m here 3')
#agentreferal = context['agentreferal']
with transaction.atomic():
self.object = form.save()
#if location.is_valid() and address.is_valid() and agentreferal.is_valid():
if agentaddress.is_valid():
#location.instance = self.object
agentaddress.instance = self.object
#agentreferal.instance = self.object
#location.save()
agentaddress.save()
#agentreferal.save()
return super(AgentAddrLocArefCreate, self).form_valid(form)
class AgentAddrLocArefUpdate(UpdateView):
model = Agent
fields = ['first_name']
success_url = reverse_lazy('agent-list')
# log.info('i m here 4')
def get_context_data(self, **kwargs):
data = super(AgentAddrLocArefUpdate, self).get_context_data(**kwargs)
log.info(data)
if self.request.POST:
log.info('i m here 5')
#data['location'] = LocationFormSet(self.request.POST, instance=self.object)
data['address'] = AgentAddressFormSet(self.request.POST, instance=self.object)
#data['agentreferal'] = AgentReferalFormSet(self.request.POST, instance=self.object)
else:
#data['location'] = LocationFormSet(instance=self.object)
data['address'] = AgentAddressFormSet(instance=self.object)
#data['agentreferal'] = AgentReferalFormSet(instance=self.object)
return data
def form_valid(self, form):
context = self.get_context_data()
#location = context['location']
agentaddress = context['address']
log.info('i m here 6')
#agentreferal = context['agentreferal']
with transaction.atomic():
self.object = form.save()
#if location.is_valid() and \
if agentaddress.is_valid():
#location.instance = self.object
agentaddress.instance = self.object
#agentreferal.instance = self.object
#location.save()
agentaddress.save()
#agentreferal.save()
return super(AgentAddrLocArefUpdate, self).form_valid(form)
def brokenview(request):
# first, intentionally log something
log.info('This is a manually logged INFO string.')
log.debug('This is a manually logged DEBUG string.')
# then have the view raise an exception (e.g. something went wrong)
raise Exception('This is an exception raised in a view.')
# return HttpResponse('hello')
sharedmodels/forms.py
from django.forms import ModelForm, inlineformset_factory
from apps.agent.models import Agent
from apps.customer.models import Customer
from .models import *
class AgentAddressForm(ModelForm):
class Meta:
model = Address
exclude = ('customer',)
class AddressForm1(ModelForm):
class Meta:
model = Address
exclude = ('agent',)
AgentAddressFormSet = inlineformset_factory(Agent, Address, form=AgentAddressForm, extra=1)
AddressFormSet1 = inlineformset_factory(Customer, Address, form=AddressForm1, extra=1)
#LocationFormSet = inlineformset_factory(Agent, Location, form=LocationForm, extra=1)
***One other point: We are successful in doing this within one app.
Any immediate help on this really appreciated.

Django-haystack generic SearchView - no results

I'm tryinig to get haystack working with a class-based generic view according to the documentation here. I can get results from a SearchQuerySet in the shell, so the models are being indexed. But I can't get the view to return a result on the page.
The main reason for using the generic view is that I want to extend later with more SQS logic.
I'm probably missing something obvious...
views.py :
from haystack.query import SearchQuerySet
from haystack.generic_views import SearchView
from .forms import ProviderSearchForm
from .models import Provider
class ProviderSearchView(SearchView):
template_name = 'search/provider_search.html'
form_class = ProviderSearchForm
def get_context_data(self, *args, **kwargs):
""" Extends context to include data for services."""
context = super(ProviderSearchView, self).get_context_data(*args, **kwargs)
context['body_attr'] = 'id="provider-search"'
return context
def get_queryset(self):
queryset = super(ProviderSearchView, self).get_queryset()
return queryset.filter(is_active=True)
search_indexes.py:
from haystack import indexes
from .models import Provider
class ProviderIndex(indexes.SearchIndex, indexes.Indexable):
text = indexes.CharField(document=True, use_template=True)
title = indexes.CharField(model_attr='name')
created = indexes.DateTimeField(model_attr='created')
def get_model(self):
return Provider
def index_queryset(self, using=None):
"Used when the entire index for model is updated."
return self.get_model().objects.all()
forms.py
from django import forms
from crispy_forms.helper import FormHelper
from crispy_forms.layout import Layout, Field, Submit
from crispy_forms.bootstrap import FieldWithButtons
from haystack.forms import SearchForm
from .models import Provider
class ProviderSearchForm(SearchForm):
""" Override the form with crispy styles """
models = [ Provider ]
def __init__(self, *args, **kwargs):
super(ProviderSearchForm, self).__init__(*args, **kwargs)
self.helper = FormHelper()
self.helper.disable_csrf = True
self.helper.form_tag = False
self.helper.form_show_labels = False
self.helper.layout = Layout (
FieldWithButtons(
Field('q', css_class='form-control input-lg', placeholder="Search providers..."),
Submit('','Search', css_class='btn btn-lg btn-primary'))
)
def get_models(self):
return self.models
def search(self):
sqs = super(ProviderSearchForm, self).search().models(*self.get_models())
return sqs
def no_query_found(self):
return self.searchqueryset.all()

The problem was that my page template was using the wrong variable in the for loop.
The documentation suggests:
for result in page_object.object_list
It should be:
for result in page_obj.object_list
note the template variable is page_obj.
See issue post on GitHub

name 'snippets' is not defined [Django Rest]

I am following the tutorial of Django REST Framework and when I try to curl http://127.0.0.1:8000/snippets, I get that error. I am new to Python/the Framework and Django, so I don't have a clue where to look at.
The code seems to be pretty fine, since I have double checked on github. Where do you think the error should be?
Snippet/serializers.py
from rest_framework import serializers
from snippets.models import Snippet
class SnippetSerializer(serializers.Serializer):
class Meta:
model = Snippet
fields = ('id', 'title','code','linenos','language','style')
class SnippetSerializer(serializers.Serializer):
pk = serializers.Field() # Note: `Field` is an untyped read-only field.
title = serializers.CharField(required=False,
max_length=100)
code = serializers.CharField(widget=widgets.Textarea,
max_length=100000)
linenos = serializers.BooleanField(required=False)
language = serializers.ChoiceField(choices=LANGUAGE_CHOICES,
default='python')
style = serializers.ChoiceField(choices=STYLE_CHOICES,
default='friendly')
def restore_object(self, attrs, instance=None):
"""
Create or update a new snippet instance, given a dictionary
of deserialized field values.
Note that if we don't define this method, then deserializing
data will simply return a dictionary of items.
"""
if instance:
# Update existing instance
instance.title = attrs.get('title', instance.title)
instance.code = attrs.get('code', instance.code)
instance.linenos = attrs.get('linenos', instance.linenos)
instance.language = attrs.get('language', instance.language)
instance.style = attrs.get('style', instance.style)
return instance
# Create new instance
return Snippet(**attrs)
snippet/urls.py
from django.conf.urls import patterns, url
urlpatterns = patterns('snippets.views',
url(r'^snippets/$', 'snippet_list'),
url(r'^snippets/(?P<pk>[0-9]+)/$', 'snippet_detail'),
)
snippet/views.py
from django.http import HttpResponse
from django.views.decorators.csrf import csrf_exempt
from rest_framework.renderers import JSONRenderer
from rest_framework.parsers import JSONParser
from snippets.models import Snippet
from snippets.serializers import SnippetSerializer
class JSONResponse(HttpResponse):
"""
An HttpResponse that renders its content into JSON.
"""
def __init__(self, data, **kwargs):
content = JSONRenderer().render(data)
kwargs['content_type'] = 'application/json'
super(JSONResponse, self).__init__(content, **kwargs)
#csrf_exempt
def snippet_list(request):
"""
List all code snippets, or create a new snippet.
"""
if request.method == 'GET':
snippets = Snippet.objects.all()
serializer = SnippetSerializer(snippets, many=True)
return JSONResponse(serializer.data)
elif request.method == 'POST':
data = JSONParser().parse(request)
serializer = SnippetSerializer(data=data)
if serializer.is_valid():
serializer.save()
return JSONResponse(serializer.data, status=201)
return JSONResponse(serializer.errors, status=400)
#csrf_exempt
def snippet_detail(request, pk):
"""
Retrieve, update or delete a code snippet.
"""
try:
snippet = Snippet.objects.get(pk=pk)
except Snippet.DoesNotExist:
return HttpResponse(status=404)
if request.method == 'GET':
serializer = SnippetSerializer(snippet)
return JSONResponse(serializer.data)
elif request.method == 'PUT':
data = JSONParser().parse(request)
serializer = SnippetSerializer(snippet, data=data)
if serializer.is_valid():
serializer.save()
return JSONResponse(serializer.data)
return JSONResponse(serializer.errors, status=400)
elif request.method == 'DELETE':
snippet.delete()
return HttpResponse(status=204)

In your file urls.py, put quotes around snippets.urls.
Like this:
url(r'^',include('snippets.urls'))

Use serializers.ModelSerializer:
class SnippetSerializer(serializers.ModelSerializer):
class Meta:
model = Snippet
fields = ('id', 'title','code','linenos','language','style')
This lets DRF know to extract the fields and their types from the specified model class Snippet as parameters for the serializer. Your current version is using only serializers.Serializer. With the base Serializer class you need to define field variables for it to work. like this example:
class SnippetSerializer(serializers.Serializer):
pk = serializers.Field() # Note: `Field` is an untyped read-only field.
title = serializers.CharField(required=False,
max_length=100)
code = serializers.CharField(widget=widgets.Textarea,
max_length=100000)
linenos = serializers.BooleanField(required=False)
language = serializers.ChoiceField(choices=LANGUAGE_CHOICES,
default='python')
style = serializers.ChoiceField(choices=STYLE_CHOICES,
default='friendly')
Additionally, its probably a better practice for you to import your views from views.py like so:
from django.conf.urls import patterns, url
import views
urlpatterns = patterns('',
url(r'^snippets/$', views.snippet_list, name='snippet-list'),
url(r'^snippets/(?P<pk>[0-9]+)/$', views.snippet_detail, name='snippet-detail'),
)

for me, what solved the problem is the file name.
make sure that the file serializers itself have no spelling issues and his name is the same as in the code.

How to pass form to Class-based generic views(TodayArchiveView)?

url.py
from django.conf.urls import patterns, include, url
import os.path
from crm.views import *
urlpatterns += patterns('',
(r'^test/$', tView.as_view()),
)
views.py
from django.views.generic import TodayArchiveView
from crm.forms import *
from crm.models import *
class tView(TodayArchiveView):
model = WorkDailyRecord
context_object_name = 'workDailyRecord'
date_field = 'date'
month_format = '%m'
template_name = "onlyWorkDailyRecord.html"
form_class = WorkDailyRecordForm ################## ADD
tView is generic view....
WorkDailyRecord is defining model in models.py
I want to pass form('WorkDailyRecordForm' class in forms.py) to template(onlyWorkDailyRecord.html)
How??
add
forms.py
from django import forms
class WorkDailyRecordForm(forms.Form):
contents = forms.CharField(label='',
widget=forms.Textarea(attrs={'placeholder': 'contents', 'style':'width:764px; height:35px;'}),
required=False,
)
target_user = forms.CharField(label='',
widget=forms.TextInput(attrs={'placeholder': 'target', 'style':'width:724px'}),
required=False,
)
onlyWorkDailyRecord.html
<form method="post" action="." class="form-inline" id="save-form">
{{ form.as_table }}
<button type="submit" class="btn btn-mini" id="workDailyRecord-add">작성</button>
</form>

In the class based views you need to mention the form_class:
form_class = WorkDailyRecordForm
A simple example:
class tView(TodayArchiveView):
form_class = WorkDailyRecordForm
template_name = 'onlyWorkDailyRecord.html'
model = WorkDailyRecord
def form_valid(self, form, **kwargs):
instance = form.save(commit=True)
return HttpResponse('Done')
def dispatch(self, request, *args, **kwargs):
return super(tView, self).dispatch(request, *args, **kwargs)
For more information read generic-editing in class based views

I had trouble with passing form class into a generic, I was able to do it by overriding the get_context_data() function, in case anyone was looking for this as well.
An example from the mozilla documentation:
class BookListView(generic.ListView):
model = Book
def get_context_data(self, **kwargs):
# Call the base implementation first to get the context
context = super(BookListView, self).get_context_data(**kwargs)
# Create any data and add it to the context
context['some_data'] = 'This is just some data'
return context
You would pass the form object into a key in the context dictionary.
Can find more information here.