I have 2 views: display_quote and quote_create.
def display_quote(request, pk):
items_quote = Quote.objects.filter(pk=pk)
items_quote_line = LineQuote.objects.all().filter(num_quote_id=pk)
form = QuoteLineForm(request.POST or None)
if request.method == "POST":
if form.is_valid():
form.save()
total = 0
for item in items_quote_line:
total = total + item.get_price()
context = {'items_quote': items_quote,
'items_quote_line': items_quote_line,
'form': form,
'total':total
}
return render(request, 'quote/quote_display.html', context)
def quote_create(request):
form = QuoteForm(request.POST or None)
if request.method == "POST":
if form.is_valid():
form.save()
return render(request, 'quote/quote_create.html', {'form': form})
After creating a quote, I want to redirect to "display_quote" (the quote creted).
Error obtained:
The view quote.views.quote_create didn't return an HttpResponse object. It returned None instead.
def quote_create(request):
form = QuoteForm(request.POST or None)
if request.method == "POST":
if form.is_valid():
form.save()
return render(request, 'quote/quote_create.html', {'form': form})
return render(request, "...", {})
return something by default. Else conditions are not handled here...
Related
How can I solve this in Django?
UnboundLocalError at / local variable 'form' referenced before assignment.
def home(request):
if request.user.is_authenticated:
form = MeepForm(request.POST or None)
if request.method == "POST":
if form.is_valid():
meep = form.save(commit=False)
meep.user = request.user
meep.save()
messages.success(request,('Meep has been posted'))
return redirect('home')
meeps = Meep.objects.all().order_by("-created_at")
return render(request, 'home/home.html', {'meeps':meeps,'form':form})
else:
meeps = Meep.objects.all().order_by("-created_at")
return render(request, 'home/home.html', {'meeps':meeps,'form':form})
Just use logic that is written similar to Django MVP views - you can just initialize the form before and then override it when it's needed with POST data.
def home(request):
form = MeepForm()
if request.user.is_authenticated:
if request.method == 'POST':
form = MeepForm(request.POST or None)
if form.is_valid():
meep = form.save(commit=False)
meep.user = request.user
meep.save()
messages.success(request, 'Meep has been posted')
return redirect('home')
meeps = Meep.objects.all().order_by("-created_at")
return render(request, 'home/home.html', {'meeps': meeps,'form': form})
The error is because of the form variable that is being referenced before it is assigned a value. In the case where the user is not authenticated, the form variable is not defined, and so you get the UnboundLocalError, try this:
def home(request):
if request.user.is_authenticated:
if request.method == 'POST':
form = MeepForm(request.POST)
if form.is_valid():
meep = form.save(commit=False)
meep.user = request.user
meep.save()
messages.success(request, 'Meep has been posted')
return redirect('home')
else:
return redirect("some_error_page")
form = MeepForm()
meeps = Meep.objects.all().order_by("-created_at")
return render(request, 'home/home.html', {'meeps': meeps,'form': form})
If your code goes into else, then you wouldn't have initialized a form object and hence the error.
else:
meeps = Meep.objects.all().order_by("-created_at")
return render(request, 'home/home.html', {'meeps':meeps,'form':form})
Here u wouldn't be having form. So initialize it here - inside else or have some value before if.
def editProfilePage(request):
if request.method =='POST':
form = UserChangeForm(request.POST, instance=request.user)
if form.is_valid():
form.save()
return redirect('profile')
else:
return render(request,'editProfile.html', {'form':form})
form = UserChangeForm(instance=request.user)
context = {'form': form}
return render(request,'editProfile.html', context)
here is the output of the terminal
the error is given below
in check_response raise ValueError(
ValueError: The view account.views.editProfilePage didn't return an HttpResponse object. It returned None instead.
there is more than one thingh wrong here, try:
def editProfilePage(request):
if request.method =='POST':
form = UserChangeForm(request.POST, instance=request.user)
if form.is_valid():
form.save()
return redirect('profile')
else:
form = UserChangeForm(instance=request.user)
context = {'form': form}
return render(request,'editProfile.html', context)
else:
form = UserChangeForm(instance=request.user)
context = {'form': form}
return render(request,'editProfile.html', context)
this code always show me error local variable 'form' referenced before assignment
def home(request):
if request.method=='POST':
form = ListForm(request.POST or None)
if form.is_valid():
form.save()
all_items = list.object.all
messages.success(request ,('Item Has Been Added To List !'))
return render(request ,'home.html', {'all_items': all_items})
else :
all_items = list.object.all
return render(request, 'home.html', {'all_items': all_items})
def home(request):
all_items = list.object.all()
if request.method=='POST':
form = ListForm(request.POST or None)
if form.is_valid():
form.save()
messages.success(request ,('Item Has Been Added To List !'))
return redirect('home.html')
else :
form = ListForm()
return render(request, 'home.html', {'all_items': all_items, 'form': form})
in case of a get request the form again will be thrown to the user
you can do this as the statement will circuit-break on the left side of the and
if 'form' in locals() and form.is_valid():
... do something
The variable form is defined only if the the condition request.method == 'POST' fulfills otherwise you won't have the from variable in the function scope. The code should look like this in order to resolve your issue:
if request.method=='POST':
form = ListForm(request.POST)
else:
form = ListForm(None)
def home(request):
if request.method == 'POST':
form = ListForm(request.POST or None)
form = ListForm(request.POST)
if form.is_valid():
form.save()
all_items = list.objects.all
messages.success(request, ('Item has been added to do list!'))
return render(request, "home.html", {'all_itmes':all_items})
else:
print(form.errors)
return HttpResponse(form.errors)
else:
all_items = list.objects.all
return render(request, "home.html", {'all_itmes':all_items})
In View 1's form their is a field called 'reference'. I need to access whatever value is submitted in that field in View 2 and set a variable equal to it. Right now I am just getting an error "orders matching query does not exist".
This is what I'm trying (I've commented the code in view2 to indicate where im getting the error).
views.py
def view1(request, pk):
item = get_object_or_404(Manifests, pk=pk)
if request.method == "POST":
form = CreateManifestForm(request.POST, instance=item)
if form.is_valid():
form.save()
return redirect('view2')
else:
form = CreateManifestForm(instance=item)
return render(request, 'edit_manifest_frombrowse.html', {'form': form})
def view2(request):
form = CreateManifestForm(request.POST)
if request.method == "POST":
if form.is_valid():
form.save()
...
reference_id = request.POST.get('reference') #this is how Im trying to get reference from the previos view
data = Manifests.objects.all().filter(reference__reference=reference_id)
form = CreateManifestForm(initial={
'reference': Orders.objects.get(reference=reference_id), #this is where im getting "does not exist"
})
total_cases = Manifests.objects.filter(reference__reference=reference_id).aggregate(Sum('cases'))
context = {
'reference_id': reference_id,
'form': form,
'data': data,
'total_cases': total_cases['cases__sum'],
}
return render(request, 'manifest_readonly.html', context)
forms.py
class CreateManifestForm(forms.ModelForm):
class Meta:
model = Manifests
fields = ('reference', 'cases', 'product_name', 'count', 'CNF', 'FOB')
I just want to be able to use whatever value is submitted in the 'reference' field in view1 in view2 and assign it equal to reference_id
Something like this:
from django.urls import reverse
def view1(request, pk):
item = get_object_or_404(Manifests, pk=pk)
if request.method == "POST":
form = CreateManifestForm(request.POST, instance=item)
if form.is_valid():
obj = form.save()
reference_id = request.POST.get('reference') or obj.reference.id
return redirect(reverse('view2')+f'?reference={reference_id}')
else:
form = CreateManifestForm(instance=item)
return render(request, 'edit_manifest_frombrowse.html', {'form': form})
def view2(request):
if request.method == "POST":
form = CreateManifestForm(request.POST)
if form.is_valid():
form.save()
...
data = getattr(request, 'POST', None) or getattr(request, 'GET', {})
reference_id = data.get('reference') #this is how Im trying to get reference from the previos view
data = Manifests.objects.all().filter(reference__reference=reference_id)
form = CreateManifestForm(initial={
'reference': Orders.objects.get(reference=reference_id), #this is where im getting "does not exist"
})
total_cases = Manifests.objects.filter(reference__reference=reference_id).aggregate(Sum('cases'))
context = {
'reference_id': reference_id,
'form': form,
'data': data,
'total_cases': total_cases['cases__sum'],
}
return render(request, 'manifest_readonly.html', context)
I use django-nocaptcha-recaptcha and followed the exact steps in the documantation: https://github.com/ImaginaryLandscape/django-nocaptcha-recaptcha
This is my view:
def home(request):
if request.method == 'POST':
form = PostForm(request.POST or None)
if form.is_valid():
save_it = form.save(commit=False)
save_it.save()
return HttpResponseRedirect(reverse(view, args=(save_it.pk,)))
else:
form = PostForm(request.POST or None)
return render(request, "home.html", locals())
I get this error message when I submit the form and the recaptcha remains unchecked:
The view posts.views.home didn't return an HttpResponse object. It returned None instead.
I hope there is no necessary information that I forgot. Any help would be appreciated
You don't return a response when your form.is_valid() is False.
Try adding this:
def home(request):
if request.method == 'POST':
form = PostForm(request.POST or None)
if form.is_valid():
save_it = form.save(commit=False)
save_it.save()
return HttpResponseRedirect(reverse(view, args=(save_it.pk,)))
else:
return render(request, "home.html", locals()) # new line
else:
form = PostForm(request.POST or None)
return render(request, "home.html", locals())
Right after I clicked send the solution occurred to me. I just needed to return the render of home.html in case the form is not valid. Sorry for the unnecessary post!