I am new to coding and have been learning a few days now. I wrote this program in Python while following along in some MIT OpenCourseware lectures and a few books. Are there anyways to more easily express the program?
Finger exercise: Write a program that asks the user to input 10 integers, and then prints the largest odd number that was entered. If no odd number was entered, it should print a message to that effect.
a = int(raw_input('Enter your first integer: '))
b = int(raw_input('Enter your second integer: '))
c = int(raw_input('Enter your third integer: '))
d = int(raw_input('Enter your fourth integer: '))
e = int(raw_input('Enter your fifth integer: '))
f = int(raw_input('Enter your sixth integer: '))
g = int(raw_input('Enter your seventh integer: '))
h = int(raw_input('Enter your eighth integer: '))
i = int(raw_input('Enter your ninth integer: '))
j = int(raw_input('Enter your tenth integer: '))
if a%2 ==0:
a = 0
else:
a = a
if b%2 ==0:
b = 0
else:
b = b
if c%2 ==0:
c = 0
else:
c = c
if d%2 ==0:
d = 0
else:
d = d
if e%2 ==0:
e = 0
else:
e = e
if f%2 ==0:
f = 0
else:
f = f
if g%2 ==0:
g = 0
else:
g = g
if h%2 ==0:
h = 0
else:
h = h
if i%2 ==0:
i = 0
else:
i = i
if j%2 ==0:
j = 0
else:
j = j
value = a, b, c, d, e, f, g, h, i, j
max = max(value)
if max ==0:
print 'There are no odd numbers.'
else:
print max, 'is the largest odd integer.'
A more compact form would be:
from __future__ import print_function
try: # Python 2
raw_input
except NameError: # Python 3 compatibility
raw_input = input
largest = None
for i in range(1, 11):
number = int(raw_input('Enter integer #%d: ' % i))
if number % 2 != 0 and (not largest or number > largest):
largest = number
if largest is None:
print("You didn't enter any odd numbers")
else:
print("Your largest odd number was:", largest)
This uses a simple loop to track how many integers were entered, but only stores the largest odd number encountered so far.
numbers = [input('Enter a number: ') for i in range(10)]
odds = [x for x in numbers if x % 2 == 1]
if odds:
print max(odds)
else:
print 'No odd numbers input'
Explanation:
numbers = [input('Enter a number: ') for i in range(10)]
This line is using a list comprehension to ask a user for 10 numbers. These numbers will be in the list object numbers
odds = [x for x in numbers if x % 2 == 1]
Next we are using another list comprehension to filter out all numbers in numbers that are not odd. Since odd numbers modulo 2 always equal 1, we are given a new list (odd) that only contains odd numbers.
if odds:
This is using python's truthy way of testing. Particularly, if a list is empty, this is False. If the list is not empty, it is True.
print max(odds)
Finally, if the above was True, we print the max value in the odds list
else:
print 'No odd numbers input'
If the if statement was False (there are no odds) we tell the user
A running copy looks like this:
Enter a number: 10
Enter a number: 12
Enter a number: 14
Enter a number: 15
Enter a number: 16
Enter a number: 17
Enter a number: 1
Enter a number: 2
Enter a number: 19
Enter a number: 2
19
Python has objects called list and tuple which represent a sequence of numbers—they serve many of the same purposes as "arrays" in other programming languages. An example of a list is [1,2,3,4,5]
Like most popular programming languages, Python also has the concept of a for loop.
myList = [1,2,3,4,5]
for x in myList:
print(x)
Python also has a somewhat unusual but very useful construct called a "list comprehension" which combines for loop, list, and an optional conditional in one neat syntax—check out these examples and see if you can understand how the result relates to the code
myNewList = [x+1 for x in myList]
myNewSelectiveList = [x+1 for x in myList if x >= 3]
and here's an example that's particularly useful in your exercise:
userInputs = [int(raw_input('Enter a number:')) for i in range(10)]
Finally, there's a function max which can take a list as its argument and which returns the largest item in the list. Once you have your 10 inputs in a list, you should be able to use these ingredients to find the highest odd number in one pretty short line (max over a list comprehension with an if conditional in it) .
I'm also studying Guttag's book from scratch. I came with the following solution:
list = []
odds = False
print('You will be asked to enter 10 integer numbers, one at a time.')
for i in range(1,11):
i = int(input('Number: '))
list.append(i)
list = sorted(list, reverse = True)
for j in list:
if j%2 == 1:
print('The largest odd number is', j, 'from', list)
odds = True
break
if odds == False:
print('There is no odd number from', list)
I went through a long(er) version similar to the OP, but since the reading list for MIT 6.00x explicitly suggested studying topic 3.2 alongside chapter 2, I thought that lists would be an acceptable answer.
The code above should allow for negatives and zero.
I'm also working through Guttag's book, this solution uses some of the above code but might have a different spin on things. I filtered out the user input right away to include only odd integer input. If all of the input is even, then the list is empty, the code checks for an empty list, then sorts whatever is left (odd integers) and returns the last one. Please let me know if there are any hidden problems in this (I'm rather new to writing algorithms as well).
arr = []
max = 0
while max < 10:
userNum = int(input('enter an int: '))
if userNum %2 != 0:
arr.append(userNum)
max = max + 1
if len(arr) == 0:
print('all are even')
oddArr = sorted(arr)
print(oddArr[-1])
I just find this question while looking for alternative answers here is my code :
Note:I changed the code a bit so I can decide how many numbers I want to enter
alist=[]
olist=[]
num=int(input("how many numbers ? : "))
for n in range(num):
numbers=int(input())
alist.append(numbers)
for n in range(len(alist)):
while alist[n]%2 != 0 :
olist.append(alist[n])
break
else:
n +=1
olist.sort()
if len(olist) != 0:
print("biggest odd number: ",olist[-1])
else:
print("there is no odd number ")
The question is very early in the book and assumes no knowledge of lists, or indeed the Nonetype (it has mentioned it but not explained how it is used). Also, some solutions here will not work if the highest odd is negative because they initialise largest = 0 before the loop.
This works:
iters = 10
largest = "spam"
while iters != 0:
user_num = int(input("Enter an integer: "))
if user_num % 2 != 0:
if largest == "spam" or user_num > largest:
largest = user_num
iters -= 1
if largest == "spam":
print("You did not enter an odd integer")
else:
print("The largest odd integer was", largest)
itersLeft = 10 #define number of integers
x=0 #creating a variable for storing values
max=0 #creating a variable for defining max
while itersLeft!=0:
x=int(input())
itersLeft = itersLeft-1
if x%2!=0 and x>max:
max=x
if max!=0:
print(max)
elif max==0:
print("No odd number was entered")
*Note: works only for non-negative numbers
The other answers and comments suggesting lists and loops are much nicer, but they're not the only way to change and shorten your code.
In your tests, the else: a = a sections are doing nothing, assigning a to itself is no change, so they can all be removed, and the if tests brought onto one line each:
a = int(raw_input('Enter your first integer: '))
b = int(raw_input('Enter your second integer: '))
c = int(raw_input('Enter your third integer: '))
d = int(raw_input('Enter your fourth integer: '))
e = int(raw_input('Enter your fifth integer: '))
f = int(raw_input('Enter your sixth integer: '))
g = int(raw_input('Enter your seventh integer: '))
h = int(raw_input('Enter your eighth integer: '))
i = int(raw_input('Enter your ninth integer: '))
j = int(raw_input('Enter your tenth integer: '))
if a%2 == 0: a = 0
if b%2 == 0: b = 0
if c%2 == 0: c = 0
if d%2 == 0: d = 0
if e%2 == 0: e = 0
if f%2 == 0: f = 0
if g%2 == 0: g = 0
if h%2 == 0: h = 0
if i%2 == 0: i = 0
if j%2 == 0: j = 0
value = a, b, c, d, e, f, g, h, i, j
max = max(value)
if max ==0:
print 'There are no odd numbers.'
That's the most obvious change that makes it easier to follow, without fundamentally changing the pattern of what you are doing.
After that, there are ways you could rewrite it - for example, staying with math only, even numbers divide by 2 with remainder 0 and odd numbers have remainder 1. So doing (x % 2) * x will change even numbers into 0, but keep odd numbers the same.
So you could replace all the if tests, with no test, just an assignment:
a = (a % 2) * a
b = (b % 2) * b
c = (c % 2) * c
...
if e%2 == 0: e = 0
if f%2 == 0: f = 0
The lines get slightly shorter, and if you're OK with how that works, you could merge those into the value line, and put that straight into max to get:
a = int(raw_input('Enter your first integer: '))
b = int(raw_input('Enter your second integer: '))
c = int(raw_input('Enter your third integer: '))
d = int(raw_input('Enter your fourth integer: '))
e = int(raw_input('Enter your fifth integer: '))
f = int(raw_input('Enter your sixth integer: '))
g = int(raw_input('Enter your seventh integer: '))
h = int(raw_input('Enter your eighth integer: '))
i = int(raw_input('Enter your ninth integer: '))
j = int(raw_input('Enter your tenth integer: '))
largest = max(a%2*a, b%2*b, c%2*c, d%2*d, e%2*e, f%2*f, g%2*g, h%2*h, i%2*i, j%2*j)
if largest == 0:
print 'There are no odd numbers.'
else:
print largest, 'is the largest odd integer.'
There isn't really a way to shorten assigning ten variables without some kind of loop, and it's arguable whether any of this is 'more easily expressing the program', but it does take 58 lines down to 17, remove 10 conditional tests, 10 else/no-op assignments and 1 variable while keeping approximately the same structure / workings.
PS. I changed max = max() because calling your variable by the same name as the function is a bad idea - you can't use the function again, and it's confusing to other Python programmers reading your code who already know what 'max' does, if you've reused that name for something else.
Edit: A commentor suggests negative numbers matter. The above writing answers "here's my code, how could I express it more easily?" without introducing any new Python or changing the behaviour, but it cannot handle negative odd numbers; max() will always choose a zero over a negative odd number, and the program will wrongly answer that "there are no odd numbers".
I don't think that's fixable without introducing any new concepts at all. And if introducing new concepts is happening, use lists and loops. Andy's suggestion to build a list that includes only the odd numbers, and then take the max value of that, for example.
But, doing something to handle them without lists -- there is another approach that hardly changes the shape of the code at all, introducing the boolean OR operation, which compares two true/false values and returns false if they are both false, otherwise true.
Python does a lot of automagic behind-the-scenes conversion to true/false to make logical operators work well. Variables with no value (zero, empty containers, empty strings) are all "false" and variables with some value are all "true".
From earlier, we have one bit that knocks even numbers to zero (a%2*a) and now we want to knock zero off the numberline completely:
-3 or None -> -3
-1 or None -> -1
0 or None -> None
1 or None -> 1
3 or None -> 3
5 or None -> 5
Introducing: a%2*a or None. It's magical, ugly, hard to follow, but valid Python -- and I'm chuffed because it's like solving a puzzle and it works, you know? Change the max line and the test to:
largest = max(a%2*a or None, b%2*b or None, c%2*c or None, d%2*d or None, e%2*e or None,
f%2*f or None, g%2*g or None, h%2*h or None, i%2*i or None, j%2*j or None)
if largest == None:
Evens get squished to zeros, zeros get squished to nothing, odds come through unchanged. Max now only has odd numbers to work with so it can now pick a negative odd number as the answer. Case closed. btw. use lists.
Compare 10 inputs and print the highest odd number
y = 0
for counter in range(10):
x = int(input("Enter a number: "))
if (x%2 == 1 and x > y):
y = x
if (y == 0):
print("All are even")
else:
print(y, "is the largest odd number")
Try the following -
def largest_odd():
q = int(input('Please enter a number: '))
w = int(input('Please enter a number: '))
e = int(input('Please enter a number: '))
lis = []
if q%2 != 0:
lis.insert (q,q)
if w%2 != 0:
lis.insert (w,w)
if e%2 != 0:
lis.insert (e,e)
Great = max(lis)
print(Great)
I am on the same exercise just now, and came up with the following solution, which seems to work just fine and is in line with the topics taught in the book so far(variable assignments, conditionals, and while loop):
EXERCISE:
Write a program that asks the user to input 10 integers, and
then prints the largest odd number that was entered. If no odd number was entered, it should print a message to that effect.
from __future__ import print_function
try: # Python 2
raw_input
except NameError: # Python 3 compatibility
raw_input = input
numbers_count = 0
next_input = 0
max_odd_number = None
while numbers_count < 10:
numbers_count += 1
next_input = raw_input("Please enter a number: " + str(numbers_count) +
" of 10\n")
if int(next_input)%2 != 0:
# on the entry of first number, we check max_odd_number - if it is of
# type None, it means no value has been assigned to it so far thus the
# first odd number entry becomes the first maximum odd number, be it
# positive or negative.
if max_odd_number == None:
max_odd_number = int(next_input)
if int(next_input) > max_odd_number:
max_odd_number = int(next_input)
if max_odd_number == None:
print ("None of the numbers entered were odd!")
else:
print ("Maximum odd number you entered is: " + str(max_odd_number))
Any comments would be appreciated.
Thanks,
A
A simple answer is :
x = 0
result = None;
while(x < 10):
inputx = raw_input('Enter integer #%d: ' % x)
inputx = int(inputx)
if (inputx % 2 == 1):
if(inputx > result):
result = inputx
x += 1
if result is None:
print 'no odd number was entered'
else:
print result
Note: if enter a String like '3f',it will throw a ValueError:
invalid literal for int() with base 10: '3f'
So finally ，the best anwser is
result = None
x = 0
while(x < 10):
inputx = raw_input('Enter integer #%d: ' % x)
try:
inputx = int(inputx)
except ValueError:
print'you enter value ',inputx,' is not a Integer. please try again!'
continue
if (inputx % 2 == 1):
if(inputx > result):
result = inputx
x+=1
if result is None:
print 'no odd number was entered'
else:
print 'the largest odd number is: ',result
The question if introduced in the book just after giving knowledge to if condition and while iteration statement.
Though there are lot many datatypes that could be used in python to get easy solution, we need to use only primitives that too the very basics.
The code below takes 10 user inputs(only odd) and outputs the largest of the 10 numbers.
Answer to the question:(Code)
a1= int(input("Enter the number1: "))
while a1%2 ==0:
print("Entered number is not an odd number.")
a1= int(input("Enter the number1: "))
a2= int(input("Enter the number2: "))
while a2%2 ==0:
print("Entered number is not an odd number.")
a2= int(input("Enter the number2: "))
a3= int(input("Enter the number3: "))
while a3%2 ==0:
print("Entered number is not an odd number.")
a3= int(input("Enter the number3: "))
a4= int(input("Enter the number4: "))
while a4%2 ==0:
print("Entered number is not an odd number.")
a4= int(input("Enter the number4: "))
a5= int(input("Enter the number5: "))
while a5%2 ==0:
print("Entered number is not an odd number.")
a5= int(input("Enter the number5: "))
a6= int(input("Enter the number6: "))
while a6%2 ==0:
print("Entered number is not an odd number.")
a6= int(input("Enter the number6: "))
a7= int(input("Enter the number7: "))
while a7%2 ==0:
print("Entered number is not an odd number.")
a7= int(input("Enter the number7: "))
a8= int(input("Enter the number8: "))
while a8%2 ==0:
print("Entered number is not an odd number.")
a8= int(input("Enter the number8: "))
a9= int(input("Enter the number9: "))
while a9%2 ==0:
print("Entered number is not an odd number.")
a9= int(input("Enter the number9: "))
a10= int(input("Enter the number10: "))
while a10%2 ==0:
print("Entered number is not an odd number.")
a10= int(input("Enter the number10: "))
if a1>a2 and a1>a3 and a1>a4 and a1>a5 and a1>a6 and a1>a7 and a1>a8 and a1>a9 and a1>a10:
print(str(a1) +" is the largest odd number.")
elif a2>a1 and a2>a3 and a2>a4 and a2>a5 and a2>a6 and a2>a7 and a2>a8 and a2>a9 and a2>a10:
print(str(a2) +" is the largest odd number.")
elif a3>a1 and a3>a2 and a3>a4 and a3>a5 and a3>a6 and a3>a7 and a3>a8 and a3>a9 and a3>a10:
print(str(a3) +" is the largest odd number.")
elif a4>a1 and a4>a2 and a4>a3 and a4>a5 and a4>a6 and a4>a7 and a4>a8 and a4>a9 and a4>a10:
print(str(a4) +" is the largest odd number.")
elif a5>a1 and a5>a2 and a5>a3 and a5>a4 and a5>a6 and a5>a7 and a5>a8 and a5>a9 and a5>a10:
print(str(a5) +" is the largest odd number.")
elif a6>a1 and a6>a2 and a6>a3 and a6>a4 and a6>a5 and a6>a7 and a6>a8 and a6>a9 and a6>a10:
print(str(a6) +" is the largest odd number.")
elif a7>a1 and a7>a2 and a7>a3 and a7>a4 and a7>a5 and a7>a6 and a7>a8 and a7>a9 and a7>a10:
print(str(a7) +" is the largest odd number.")
elif a8>a1 and a8>a2 and a8>a3 and a8>a4 and a8>a5 and a8>a6 and a8>a7 and a8>a9 and a8>a10:
print(str(a8) +" is the largest odd number.")
elif a9>a1 and a9>a2 and a9>a3 and a9>a4 and a9>a5 and a9>a6 and a9>a7 and a9>a8 and a9>a10:
print(str(a9) +" is the largest odd number.")
else:
print(str(a10) +" is the largest odd number.")
Hope this helps.
In my experience the way to more easily express the program is with a function.
This would have been my answer in Syntax tested for Python 3.7.6:
'''
Finger exercise:
Write a program that asks the user to input 10 integers,
and then prints the largest odd number that was entered.
If no odd number was entered, it should print a message to that effect.
'''
def LargestOdd(numbers=[]):
'''
Parameters
----------
numbers : list, whcih should contain 10 integers.
DESCRIPTION. The default is [].
Returns
-------
The largest odd integer in the list number.
'''
odd_numbers=[]
if len(numbers)==10:
for n in numbers:
if n%2 != 0:
odd_numbers.append(n)
max_numb=max(odd_numbers)
print('The largest odd number is '+str(max_numb))
else:
print('Please, enter 10 numbers')
LargestOdd([1,2,3,7,45,8,9,10,30,33])
Output: The largest odd number is 45
n = int(input("Enter the no of integers:"))
lst = []
count = 1
while count <=n:
no = int(input("Enter an integer:"))
count = count +1
if (no%2!=0):
lst.append(no)
print ("The list of odd numbers",lst)
print("The maximum number from the list of odd number is:",max(lst))
Here is my solution:
def max_odd():
"""Returns largest odd number from given 10 numbers by the use.
if the input is not valid, the message is displayed to enter valid numbers"""
x = [input('Enter a value: ') for i in range(10)]
x = [int(i) for i in x if i]
if x:
try:
x = [i for i in x if i%2 != 0]
return(max(x))
except:
return('All even numbers provided.')
else:
return('Please enter a valid input')
I started learning coding from Guttag's book. And since this is in the 2nd chapter, the solution follows only basic if condition and while loop
#input 10 integers
n1 = int(input('Enter 1st integer: '))
n2 = int(input('Enter 2nd integer: '))
n3 = int(input('Enter 3rd integer: '))
n4 = int(input('Enter 4th integer: '))
n5 = int(input('Enter 5th integer: '))
n6 = int(input('Enter 6th integer: '))
n7 = int(input('Enter 7th integer: '))
n8 = int(input('Enter 8th integer: '))
n9 = int(input('Enter 9th integer: '))
n10 = int(input('Enter 10th integer: '))
#create list from input
list = [n1,n2,n3,n4,n5,n6,n7,n8,n9,n10]
largest = list[0] #Assign largest to the first integer
x = 1 #index starts at 1
while x < len(list):
if list[x]%2 != 0:
if list[x] > largest:
largest = list[x]
x += 1
if largest%2 == 0:
print('All numbers are even')
else:
print('Largest odd number is', largest)
#This is the simplest program for this question
a=[input('Enter a number: ') for i in range(10)]
#This gets 10 inputs from the user and stores it as a string in a list
b=[int(a[i]) for i in range(10)]
#Here the string values were converted into integer values
for i in range(10):
if max(b)%2==0:
b.remove(max(b))
#Now the loop checks for the max number and if it's even it deletes it.
c=max((b),default='Nil')
if c=="Nil":
print("Please enter an odd number")
else:
print(c,"Is the Largest Odd Number")
#Now the largest number left is an odd number and we finally print it!!!!
This code should work work as well. Syntax tested for python 2.7
def tenX(): #define function
ten = [] #empty list for user input
odds = [] #empty list for odd numbers only
counter = 10
ui = 0
while counter > 0 :
ui = raw_input('Enter a number: ')
ten.append(int(ui)) #add every user input to list after int conversion
counter -= 1
for i in ten:
if i % 2 != 0:
odds.append(i)
print "The highest number is", max(odds) #max() returns highest value in a list
>>> tenX() #call function
Related
I have an exercise:
Write code that asks the user for integers, stops loop when 0 is given.
Lastly, adds all the numbers given and prints them.
So far I manage this:
a = None
b = 0
while a != 0:
a = int(input("Enter a number: "))
b = b + a
print("The total sum of the numbers are {}".format(b))
However, the code needs to check the input and give a message incase it is not an integer.
Found that out while searching online but for the life of me I cannot combine the two tasks.
while True:
inp = input("Input integer: ")
try:
num = int(inp)
except ValueError:
print('was not an integer')
continue
else:
total_sum = total_sum + num
print(total_sum)
break
I suspect you need an if somewhere but cannot work it out.
Based on your attempt, you can merge these two tasks like:
a = None
b = 0
while a != 0:
a = input("Enter a number: ")
try:
a = int(a)
except ValueError:
print('was not an integer')
continue
else:
b = b + a
print("The total sum of the numbers are {}".format(b))
If you want to use an If-Statement, you don't need the else: If the number is not 0 it will just start again until it's 0 sometime.
total_sum = 0
while True:
inp = input("Input integer: ")
try:
num = int(inp)
except ValueError:
print('was not an integer')
continue
total_sum = total_sum + num
if num == 0:
print(total_sum)
break
Since input's return is a string one can use isnumeric no see if the given value is a number or not.
If so, one can convert the string to float and check if the given float is integer using, is_integer.
a = None
b = 0
while a != 0:
a = input("Enter a number: ")
if a.isnumeric():
a = float(a)
if a.is_integer():
b += a
else:
print("Number is not an integer")
else:
print("Given value is not a number")
print("The total sum of the numbers are {}".format(b))
I would like to request for five numbers from the user and print the numbers in a list followed by the sum of the numbers:
i.e.
For my code it prints this instead,
This is my code:
#prompt for 5 numbers
x=1
num=0
while True:
try:
sum = 0
for y in range (1,6,1):
num = int (input("number:"))
sum = sum + num
print("number",x,":",num)
x += 1
print ("Sum of numbers: ", sum)
except ValueError:
print("Please enter a valid number")
continue
How may I fix it such that it prints in a list instead?
Is this what you meant
#prompt for 5 numbers
x=1
num=0
while True:
try:
sum = 0
for y in range (1,6,1):
num = int (input("number "+str(x)+":"))
sum = sum + num
x += 1
print ("Sum of numbers: ", sum)
x=1
except ValueError:
print("Please enter a valid number")
continue
Worked Example
number 1:2
number 2:5
number 3:4
number 4:8
number 5:1
Sum of numbers: 20
Try this,
numbers = [int(input()) for _ in range(5)]
print(': '.join(map(lambda x: f'number{x}',numbers))+': Sum: '+str(sum(numbers)))
Output:
number1: number2: number3: number4: number5: sum: 15
I found the problem and it's quite simple, really
Rename sum to something else like total. Sum actually means something else(it is a keyword)
So your code should look like this-
#prompt for 5 numbers
x=1
num=0
while True:
try:
total = 0
for y in range (1,6,1):
num = int (input("number:"))
total += num
print("number",x,":",num)
x += 1
print ("Sum of numbers: ", total)
except ValueError:
print("Please enter a valid number")
continue
print("\tWELCOME TO DRY_RUN CLASS ASSAIGNTMENT!\t")
userList = []
def mainSystem():
number = 1
userInput = int(input("Enter the size of the List: "))
if userInput > 0:
for x in range(0, userInput):
variable = int(input(print("Enter number",number )))
number = number + 1
userList.append(variable)
else:
print("Number should not be less than or equal to '0'!")
def maxAll():
maxofall = 0
for element in userList:
if element > maxofall:
maxofall = element
print("The maximum number is:", element)
while True:
mainSystem()
askUser = int(input("What do you want to do with the numbers?\n1.Max All\n2.Average\n3.Quit\nYour answer: "))
if askUser == 1:
maxAll()
this is the code i am using right now...
what do i need to fix i am getting an error like this wheni am executing line no. 9
:-
Enter Number whatever the number is
Noneinput starts here
???
def mainSystem():
number = 1
userInput = int(input("Enter the size of the List: "))
if userInput > 0:
for x in range(0, userInput):
variable = int(input("Enter number {} : ".format(number) ))
number = number + 1
userList.append(variable)
else:
print("Number should not be less than or equal to '0'!")
Change your function to this.
print() is a function. Which returns nothing (None) in your case.
input() function thinks this None object is worth displaying on console.
Hence None appears on screen before taking any input.
There are a couple of problems:
1)You have a misplaced print() inside input() in your mainSystem() function
2)You probably want to use f-strings to print the right number instead of the string literal 'number'
def mainSystem():
number = 1
userInput = int(input("Enter the size of the List: "))
if userInput > 0:
for x in range(0, userInput):
variable = int(input(f"Enter number {number} : "))
number = number + 1
userList.append(variable)
We have to find out the average of a list of numbers entered through keyboard
n=0
a=''
while n>=0:
a=input("Enter number: ")
n+=1
if int(a)==0:
break
print(sum(int(a.list()))/int(n))
You are not saving the numbers entered. Try :
n = []
while True:
a=input("Enter number: ")
try: #Checks if entered data is an int
a = int(a)
except:
print('Entered data not an int')
continue
if a == 0:
break
n.append(a)
print(sum(n)/len(n))
Where the list n saves the entered digits as a number
You need to have an actual list where you append the entered values:
lst = []
while True:
a = int(input("Enter number: "))
if a == 0:
break
else:
lst.append(a)
print(sum(lst) / len(lst))
This approach still has not (yet) any error management (a user enters float numbers or any nonsense or zero at the first run, etc.). You'd need to implement this as well.
a needs to be list of objects to use sum, in your case its not. That is why a.list doens't work. In your case you need to take inputs as int (Can be done like: a = int(input("Enter a number")); ) and then take the integer user inputs and append to a list (lets say its name is "ListName")(listName.append(a)), Then you can do this to calculate the average:
average = sum(listName) / len(listName);
def calc_avg():
count = 0
sum = 0
while True:
try:
new = int(input("Enter a number: "))
if new < 0:
print(f'average: {sum/count}')
return
sum += new
count += 1
print(f'sum: {sum}, numbers given: {count}')
except ValueError:
print("That was not a number")
calc_avg()
You can loop, listen to input and update both s (sum) and c (count) variables:
s, c = 0, 0
while c >= 0:
a = int(input("Enter number: "))
if a == 0:
break
else:
s += a
c += 1
avg = s/c
print(avg)
I just started learning python. I have some experience with C++ from school. The problem is to write code that prints the largest odd number from user input and to print relevant feedback if there isn't any odd number. What is wrong with this code and are there better ways to solve this problem?
#To print the largest odd number
x = input ("Enter first number: ")
y = input ("Enter second number: ")
z = input ("Enter third number: ")
if x % 2 == 0 and y % 2 == 0 and z % 2 == 0:
print ("There are no odd numbers")
if x % 2 != 0 and x > y and x > z:
print (x, " is the largest odd number")
if y % 2 != 0 and y > x and y > z:
print (y, " is the largest odd number")
if z % 2 != 0 and z > x and z > y:
print (z, " is the largest odd number")
elif x == y == z:
print ("All the numbers have the same value")
Maybe the logic becomes easier if you make it into a small list and sort it:
x = input ("Enter first number: ")
y = input ("Enter second number: ")
z = input ("Enter third number: ")
odds = sorted([ i for i in [x,y,z] if int(i)%2 ],reverse=True)
if not odds:
print("No odd number")
elif odds.count(odds[0]) == len(odds):
print("All odd numbers are equal")
else:
print(f"{odds[0]} is the largest odd number")
2 things: 1. Convert data. 2. Your code isn't formatted correctly, by the looks of it.
For 1:
x = int(input(("Enter first number: ")) #Do this for y and z
For 2- your code will never return the largest odd number if the largest odd number is smaller than the largest even number. For example [20, 9, 5]. To fix that:
#Create a list to work with
num_li = [x,y,z]
#Get all the odd numbers
num_li = [i for i in num_li if i%2!=0]
#If no odd numbers
if len(num_li) == 0:
print('No odds')
#Print the largest odd number
else:
num_li.sort(reverse = True)
print('The largest odd number is: ' + str(num_li[0]))
There are two problems with the current version of the code:
1)TypeError - You are receiving strings as inputs and treating them like integers
2)Logical error - your conditions do not cover all cases.
I rewrote the code. strings are converted to int and all cases are covered.
Working example:
x = int(input ("Enter first number: "))
y = int(input ("Enter second number: "))
z = int(input ("Enter third number: "))
numbers = [x, y, z]
odd_numbers = []
for number in numbers: // loop through the numbers and create an odd number list
if number % 2 != 0:
odd_numbers.append(number)
if odd_numbers: //print out the largest number in the list using max()
print(max(odd_numbers))
else:
print("No odd numbers")// if the list is empty this will be printed