Strikes loops infinitely, and I can't fix it. New to Python so forgive any rookie mistakes. Not fully understanding the syntax yet but I've only been at it for three days. I assume it's because of indentation but I'm not sure. Thanks in advance!
import random
words = [
'burger',
'fettucine',
'lasanga',
'steak',
'garlic bread'
'watermelon',
'tea',
'pineapple'
'coffee',
'shrimp penne'
]
while True:
start = input("Press enter to start, or press Q to quit.")
if start.lower() == 'q':
break
secret_word = random.choice(words)
bad_guesses = []
good_guesses = []
while len(bad_guesses) < 10 and len(good_guesses) != len(list(secret_word)):
for letter in secret_word:
if letter in good_guesses:
print(letter, end='')
else:
print('_', end='')
print('')
print('Strikes: {}/10'.format(len(bad_guesses))) # this is what loops
print('')
guess = input("Guess a letter: ").lower()
if len(guess) != 1:
print("You can only guess one letter!")
continue
elif guess in bad_guesses or guess in good_guesses:
print("You have already guessed that letter.")
continue
elif not guess.isalpha():
print("You can only guess letters.") continue
if guess in secret_word:
good_guesses.append(guess) if len(good_guesses) == len(list(secret_word)): print("You win! The word was {}.".format(secret_word))
break
else: bad_guesses.append(guess)
else: print("You didn't get it. The word was{}.".format(secret_word))
Fixed code below.
I found a few issues:
Some indentation and newlines seem to have been lost when you shared the code.
You can't guess spaces, so it's impossible to solve the puzzles that contain spaces ("garlic bread" and "shrimp penne").
There were missing commas after 'garlic bread' and 'pineapple'.
The code that asks for a new guess needs to be inside the inner while loop.
There was an else with no if... I got rid of the else and put that code outside the while loop. Now the game seems to work fine.
Full fixed code here:
import random
words = [
'burger',
'fettucine',
'lasanga',
'steak',
# commented out since you can't guess spaces
# 'garlic bread',
'watermelon',
'tea',
'pineapple',
'coffee',
# commented out since you can't guess spaces
# 'shrimp penne',
]
while True:
start = input("Press enter to start, or press Q to quit.")
if start.lower() == 'q':
break
secret_word = random.choice(words)
bad_guesses = []
good_guesses = []
while len(bad_guesses) < 10 and len(good_guesses) != len(list(secret_word)):
for letter in secret_word:
if letter in good_guesses:
print(letter, end='')
else:
print('_', end='')
print('')
print('Strikes: {}/10'.format(len(bad_guesses))) # this is what loops
print('')
guess = input("Guess a letter: ").lower()
if len(guess) != 1:
print("You can only guess one letter!")
continue
elif guess in bad_guesses or guess in good_guesses:
print("You have already guessed that letter.")
continue
elif not guess.isalpha():
print("You can only guess letters.")
continue
if guess in secret_word:
good_guesses.append(guess)
if len(good_guesses) == len(list(secret_word)):
print("You win! The word was {}.".format(secret_word))
break
else:
bad_guesses.append(guess)
print("You didn't get it. The word was {}.".format(secret_word))
Related
trying to make a game where if you reach a certain number of guesses the while loop breaks
secret_word = "giraffe"
guess = ""
guess_count = 0
while guess != secret_word:
guess = input("enter guess: ")
guess_count += 1
print(guess_count)
if guess == secret_word:
print("You win")
else guess_count == "4":
print("You lost!")
break
Your code is almost there, you just need to make a few changes. First, you need a break statement within your win condition so the loop stops. Second, you need to change else to elif, or simply just an if. Also, you need to compare guess_count to an int, not a str.
Code:
secret_word = "giraffe"
guess = ""
guess_count = 0
while guess != secret_word:
guess = input("enter guess: ")
guess_count += 1
print(guess_count)
if guess == secret_word:
print("You win")
break
elif guess_count == 4:
print("You lost!")
break
Output:
enter guess:
dog
1
enter guess:
dog
2
enter guess:
dog
3
enter guess:
dog
4
You lost!
I kind of reformated the code, having else with a condition didn't really make sense so I switched it to:
secret_word = "giraffe"
guess = ""
guess_count = 0
limit = 4
while guess_count < limit:
guess = input("enter guess: ")
guess_count += 1
print(guess_count)
if guess == secret_word:
print("Congrats, You Win!!")
quit()
print('Sorry, too many guesses, you lose! :(')
Good luck with the game!!
I am creating a hangman game.Here are the conditions
User will be given six chances for wrong choices
If the letter was already entered, user will be notified that letter already exists (user will not be penalised for double wrong entry)
Now my question is :
I want to display the message that "user lost the game" if the number of wrong guessed letters goes to 7 and exists the loop but it is not happening
here is my code:
print("Welcome to Hangman"
"__________________")
word = "Python"
wordlist=list(word)
wordlist.sort()
print(wordlist)
print("Word's length is", len(word))
letter=" "
used_letter=[]
bad_letter=[]
guess=[]
tries=0
while len(bad_letter)<7:
while guess != wordlist or letter !="exit":
letter = input("Guess your letter:")
if letter in word and letter not in used_letter:
guess.append(letter)
print("good guess")
elif letter in used_letter:
print("letter already used")
else:
bad_letter.append(letter)
print("bad guess")
used_letter.append(letter)
tries+=1
print("You have ",6 - len(bad_letter), " tries remaining")
print(guess)
print("You have made ",tries," tries so far")
guess.sort()
print("Thank you for playing the game, you guessed in ",tries," tries.")
print("Your guessed word is", word)
print("you lost the game")
I am very new to python so i would appreciate help in basic concepts
It seems like your while len(bad_letter) < loop is never exiting because of the while loop below it which is checking for the right answer or exit entry runs forever.
What you should do is only have one master while loop which takes in a new input each time and then check to see if that input matches any of the conditions you are looking for.
You could structure it something like this:
bad_letter = []
tries = 0
found_word = False
while len(bad_letter) < 7:
letter = input("Guess your letter:")
if letter == 'exit':
break # Exit game loop
if letter in word and letter not in used_letter:
guess.append(letter)
print("good guess")
elif letter in used_letter:
print("letter already used")
else:
bad_letter.append(letter)
print("bad guess")
used_letter.append(letter)
tries+=1
print("You have ", 6 - len(bad_letter), " tries remaining")
print(guess)
print("You have made ",tries," tries so far")
guess.sort()
if guess == wordlist:
found_word = True
break # Exits the while loop
print("Thankyou for playing tha game, you guessed in ",tries," tries.")
print("Your guessed word is", word)
if found_word:
print("You won")
else:
print("you lost the game")
Solution
word = 'Zam'
guesses = []
guesses_string = ''
bad_guesses = []
chances = 6
def one_letter(message=""):
user_input = 'more than one letter'
while len(user_input) > 1 or user_input == '':
user_input = input(message)
return user_input
while chances > 0:
if sorted(word.lower()) == sorted(guesses_string.lower()):
print("\nYou guessed every letter! (" + guesses_string + ")")
break
guess = one_letter("\nGuess a letter: ")
if guess in guesses or guess in bad_guesses:
print("You already guessed the letter " + guess + ".")
continue
elif guess.lower() in word.lower():
print("Good guess " + guess + " is in the word!.")
guesses.append(guess)
guesses_string = ''.join(guesses)
print("Letters guessed: " + guesses_string)
else:
print("Sorry, " + guess + " is not in the word.")
bad_guesses.append(guess)
chances -= 1
print(str(chances) + " chances remaning.")
if chances == 0:
print("\nGame Over, You Lose.")
else:
word_guess = ''
while word_guess.lower() != word.lower():
word_guess = input("Guess the word: ('quit' to give up) ")
if word_guess.lower() == 'quit':
print("You gave up, the word was " + word.title() + "!")
break
if word_guess.lower() == word.lower():
print("\nCongratulations YOU WON! The word was "
+ word.title() + "!")
Hey there! I'm new to programming (week 2) and keep seeing these 'hangman' games popup, since today is my break from learning, I the goals you were trying to achieve and ran with it.
Added some extra features in here such as breaking the loop if the all letters are guessed, and then asking the user to guess the final word.
Notes
There is a ton of Refactoring you could do with this(almost breaks my heart to post this raw form) but I just blurted it on on the go.
Also note that my original goal was to stick to your problem of not allowing the same letter to be entered twice. So this solution only works for words that contain no duplicate letters.
Hope this helps! When I get some time I'll Refactor it and update, best of luck!
Updates
Added bad_guesses = [] allows to stop from entering bad guess twice.
I think the problem is with my second while loop. It keeps printing the _ after I press enter to run the game. I'm not sure how the condition isn't being met or where to add a break. I have tried changing the indentation of my else: and when I do the loop won't run at all.
import random
#make a list of words
words = [
'apple',
'banana',
'orange',
'coconut',
'strawberry',
'lime',
'grapefruit',
'lemon',
'kiwi',
'blueberry',
'melon'
]
while True:
start = input("Press enter/return to start, or Q to quit")
if start.lower() == 'q':
break
#pick rand word
secret_word = random.choice(words)
bad_guesses = []
good_guesses = []
while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
#draw guessed letters, spaces, and strikes
for letter in secret_word:
if letter in good_guesses:
print(letter, end='')
else:
print('_', end='')
print('')
print('Strikes: {}/7'.format(len(bad_guesses)))
print('')
#take guess
guess = input("Guess a letter: ").lower()
if len(guess) != 1:
print("You can only guess a single letter!")
continue
elif guess in bad_guesses or guess in good_guesses:
print("You already guessed that letter!")
continue
elif not guess.isalpha():
print("You can only guess letters!")
continue
if guess in secret_word:
good_guesses.append(guess)
if len(good_guesses) == len(list(secret_word)):
print("You Win! The word was {}".format(secret_word))
break
else:
bad_guesses.append(guess)
else:
print("You didn't get it! My secret word was {}".format(secret_word))
Here is a working version of your code. Just corrected the necessary parts, but undoubtedly you should consider writing a more clean, and better indented code.
import random
# make a list of words
words = [
'apple',
'banana',
'orange',
'coconut',
'strawberry',
'lime',
'grapefruit',
'lemon',
'kiwi',
'blueberry',
'melon'
]
while True:
start = input("Press enter/return to start, or Q to quit")
if start.lower() == 'q':
break
bad_guesses = []
good_guesses = []
# pick rand word
secret_word = random.choice(words)
while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
# draw guessed letters, spaces, and strikes
for letter in secret_word:
if letter in good_guesses:
print(letter, end='')
else:
print('_', end='')
print('\Bad guesses: {}/7\n'.format(len(bad_guesses)))
# take guess
guess = input("Guess a letter: ").lower()
if len(guess) != 1:
print("You can only guess a single letter!")
continue
elif guess in bad_guesses or guess in good_guesses:
print("You already guessed that letter!")
continue
elif not guess.isalpha():
print("You can only guess letters!")
continue
if guess in secret_word:
good_guesses.append(guess)
else:
bad_guesses.append(guess)
if len(good_guesses) == len(set(secret_word)):
print("You Win! The word was {}".format(secret_word))
break
print("You didn't get it! My secret word was {}".format(secret_word))
In the block with this condition:
while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
nothing changes about the bad_guesses, good_guesses, or secret_word variables. That means you'll just keep retrying it forever.
You probably wanted an if not a while in that case.
How do i check for a repeating input(letter) for a hangman game?
Example:
word is apple
input is Guess a letter: a
output is Well Done!
then guess next word
input is Guess a letter: a
output should be you already guess that letter.
my codes:
def checkValidGuess():
word = getHiddenWord()
lives = 10
num = ["1","2","3","4","5","6","7","8","9",]
#guessed = ''
while lives != 0 and word:
print("\nYou have", lives,"guesses left")
letter = input("Guess a letter or enter '0' to guess the word: ")
if letter.lower() in word:
print("Well done!", letter, "is in my word!")
lives -= 1
elif len(letter)>1:
print("You can only guess one letter at a time!")
print("Try again!")
elif letter in num:
print("You can only input letter a - z!")
print("Try again!")
#elif letter in guessed:
#print("repeat")
elif letter == "0":
wword = input("What is the word?").lower()
if wword == word:
print("Well done! You got the word correct!")
break
else:
print("Uh oh! That is not the word!")
lives -= 1
#elif letter == "":
#print("Uh oh! the letter you entered is not in my word.")
#print("Try again!")
else:
print("Uh oh! the letter you entered is not in my word.")
print("Try again!")
lives -= 1
Thanks.
You could store the inputs in a list, let's call it temp.
Then you could check to see if the input exists in the list when the user goes to input a new letter.
guess = input()
if guess in temp:
print "You've already guessed {}".format(guess)
else:
#do whatever you want
Here's an easy way. Start by initializing a list:
guesses = []
Then in your loop:
letter = input("Guess a letter or enter '0' to guess the word: ")
if letter in guesses:
print("Already guessed!")
continue
guesses.append(letter)
So you probably want to invert the order of your checks in your program so that you deal with the try again stuff first. Following that change, add another condition that determines if the letter matches those already guessed. This results in something like:
already_guessed = set() # I made this a set to only keep unique values
while lives > 0 and word: # I changed this to test > 0
print(f"\nYou have {lives} guesses left") # I also added an f-string for print formatting
letter = input("Guess a letter or enter '0' to guess the word: ")
if len(letter) > 1:
print("You can only guess one letter at a time!")
print("Try again!")
continue # If you reach this point, start the loop again!
elif letter in already_guessed:
print("You already guessed that!")
print("Try again")
continue
elif letter in num:
print("You can only input letter a - z!")
print("Try again!")
continue
elif letter.lower() in word:
print("Well done!", letter, "is in my word!")
lives -= 1
else:
already_guessed.update(letter)
# It wasn't a bad character, etc. and it wasn't in the word\
# so add the good character not in the word to your already guessed
# and go again!
You would need to add your other conditional branches, but this should get you there. Good luck.
I am creating a hangman game for my GCSE Computing Project. I have come across an error that I cannot seem to rectify.
This is all of the code:
import random
#Creates a tuple with words in
WORDS = ("church","smelly","chicks")
#This picks a word randomly
word = random.choice(WORDS)
print("The word is", len(word), "letters long.")
#This is the game
for i in range(1):
letter1 = input ("Guess a letter:")
if letter1 in word:
print("Correct. This letter is in the word")
else:
print("Incorrect. This letter is not in the word.")
for i in range(1):
letter2 = input ("Guess a letter:")
if letter2 in word:
print("Correct. This letter is in the word")
else:
print("Incorrect. This letter is not in the word.")
for i in range(1):
letter3 = input ("Guess a letter:")
if letter3 in word:
print("Correct. This letter is in the word")
else:
print("Incorrect. This letter is not in the word.")
for i in range(1):
letter4 = input ("Guess a letter:")
if letter4 in word:
print("Correct. This letter is in the word")
else:
print("Incorrect. This letter is not in the word.")
for i in range(1):
letter5 = input ("Guess a letter:")
if letter5 in word:
print("Correct. This letter is in the word")
else:
print("Incorrect. This letter is not in the word.")
for i in range(1):
letter6 = input ("Guess a letter:")
if letter6 in word:
print("Correct. This letter is in the word")
else:
print("Incorrect. This letter is not in the word.")
all_letters = [letter1, letter2, letter3, letter4, letter5, letter6]
# Conditions for winning/losing
if all_letters in word:
print("Well done, you got it.")
else:
print("Sorry, You are the loser.")
When I run the program, I get this error
TypeError: 'in <string>' requires string as left operand, not list
I am not sure how to fix this error, can someone please help me?
Also, if you're able to, can you give me some advice on what to improve any section of the whole code.
*This is my first question, forgive me if I've been a bit extensive"
You should do it as follows instead:
if all(i in word for i in all_letters):
print("Well done, you got it.")
else:
print("Sorry, You are the loser.")
This will print 'Well done, you got it.' only if all the letters are in word. It makes use of the all built-in.