We Keep Coding

Find And Replace Character In Python

For the get_letter_from_user function, while using the while loop for validation, it keeps repeating the invalid input; I want to make sure that it is a single letter and lower case, and I want to make sure that it doesn't equal the second parameter of the function. I'm not sure what I'm doing wrong, though. (and how to get gud at coding if u have tips)
def get_text_from_user(prompt):
return input(prompt).lower()
def get_letter_from_user(prompt, not_allowed):
not_allowed = ''
allowed = input(prompt).lower()
while not allowed == not_allowed or allowed.isalpha() or len(allowed) > 1:
allowed = str(input('Invalid letter, try again:'))
return allowed
def main():
text = get_text_from_user("Enter some text: ")
ltr1 = get_letter_from_user("Enter a letter: ", '')
ltr2 = get_letter_from_user("Enter another letter: ", ltr1)
new_text = text.replace(ltr1,ltr2)
print("The new text is", new_text)
if __name__ == "__main__":
main()

Suggestion for the function:
def get_letter_from_user(prompt, not_allowed):
allowed = input(prompt).lower()
while allowed == not_allowed or len(allowed) > 1:
print('not_allowed:',not_allowed)
allowed = str(input('Invalid letter, try again:'))
return allowed
ltr1 = get_letter_from_user("Enter a letter: ", '')
ltr2 = get_letter_from_user("Enter another letter: ", ltr1)
Sample output:
Enter a letter: d
Enter another letter: d
not_allowed: d
Invalid letter, try again:d
not_allowed: d
Invalid letter, try again:a

To replace a letter or sequence of letters in a string, you might want to take a look at the string.replace() function:
text = input('Enter some text: ')
find = input('Enter a letter to replace: ')
replace_with = input(f'Enter a letter to replace \'{find}\' with: ')
replaced = text.replace(find, reolace_with)
print('The new text is:', replaced)

To add another little detail because you asked how to get better at coding:
I would never make a function with a parameter that is immediately changed to an empty string. Like:
def get_letter_from_user(prompt, not_allowed):
not_allowed = ''
Rather use a default value like this:
def get_letter_from_user(prompt, not_allowed=''):
...

Can't append the last word from a text file to a list

I want to make a list of words contained in a text file. But my code prints all but the last word of the file. What am I doing wrong ?
def word_map(file):
text = file.read()
word = "" # used as a temporary variable
wordmap = []
for letter in text:
if letter != " ":
word = word+letter
else:
wordmap.append(word)
word = ""
return set(wordmap)

Just use wordmap = text.split(" ")
I hope this helped, good luck.

When exiting the loop you are not appending the last word, just try this:
def word_map(file):
text = file.read()
word = "" # used as a temporary variable
wordmap = []
for letter in text:
if letter != " ":
word = word+letter
else:
wordmap.append(word)
word = ""
wordmap.append(word)
return set(wordmap)

I think you're missing a final :
wordmap.append(word)
Because if your text file does not end with a space, it won't be appended

infinite loop in Hangman game in Python

I am trying to build a simple Hangman game, but the following program is creating an infinite loop when the letter entered by the user is not part of the word to guess (it's printing "*" indefinitely). What is missing here? Any advice would be appreciated.
import re
import random
folder = open("datas.txt","r")
data = folder.read()
word_list = re.sub("[^\w]"," ", data).split()
chosen_word = random.choice(word_list)
letter_player = input('enter a letter pls:\n')
continue_game = False
masked_word = []
for letter in chosen_word:
masked_word.append("*")
found_letters = []
def guess_letter():
for letter in range(0,len(chosen_word)):
if letter_player == chosen_word[letter]:
found_letters.append(letter_player)
masked_word[letter] = letter_player
else:
masked_word[letter] = '*'
print(masked_word[letter])
return found_letters
str_found_letters = ''.join(found_letters)
print(str_found_letters)
if(str_found_letters != chosen_word):
continue_game = True
while continue_game:
guess_letter()

As there are others answering, why not hand out another try, from where the OP could continue? So here another version fixing also the overwrite error of previous found letters in subsequent iterations.Note also, that the append of letters found in a list may be what one wants, or maybe not, as the o in foo would be appended twice.
# Python 3/2, imports and a literal:
from __future__ import print_function
import re
import random
MASK_CHAR = '*'
# Read words from file and select randomly:
def read_game_data(source="datas.txt"):
"""Randomly select a word from source data."""
with open(source, "r") as f_data:
return random.choice(re.sub("[^\w]", " ", f_data.read()).split())
# Build sequences (here lists) of letters that constitute a word or "mask"
def build_word_seq(a_word, a_mask=None):
return [letter if not a_mask else a_mask for letter in a_word]
# the core evaluation function (previously named guess_letter)
def evaluate_letter(chosen_word, masked_word, letter_player, found=None):
if found is None:
found = set()
for pos in range(len(chosen_word)):
if letter_player == chosen_word[pos]:
found.add(letter_player)
masked_word[pos] = letter_player
return masked_word, found
# The function that replaces the continue_game variable:
def not_ready(chosen_word, masked_word):
"""Evaluate."""
return True if masked_word != chosen_word else False
# Put the business in a main function, minimize globals:
def main():
"""Do the game."""
chosen_word = build_word_seq(read_game_data())
mask = build_word_seq(chosen_word, a_mask=MASK_CHAR)
found_letters = set()
while not_ready(chosen_word, mask):
letter_player = input('enter a letter pls:\n')
mask, found_letters = evaluate_letter(
chosen_word, mask, letter_player, found_letters)
print(''.join(mask))
if found_letters:
print("LettersFound: %s" % (sorted(found_letters),))
if __name__ == '__main__':
main()
A typical run based on a datas.txt file with:
foo bar baz
yes
no
yields e.g:
$ python3 hangman_again_inf_loop.py
enter a letter pls:
f
***
enter a letter pls:
y
***
enter a letter pls:
b
b**
LettersFound: ['b']
enter a letter pls:
a
ba*
LettersFound: ['a', 'b']
enter a letter pls:
r
bar
LettersFound: ['a', 'b', 'r']
The loop again may be infinite (if you do not guess right ;-)
For a hangman game, there should be some equivalent counting logic, where the guessing competes against a line by line drawn hangman ...
Above code still needs replacement of input() by raw_input() when python v2 is being used ... but the OP used print() without future import, thus it is plausible, a Python v3 solution is good nuff.
Happy hacking!

So, the biggest issue was the scope of the continue_game variable. Since it was declared outside of the function. "while continue_game" always evaluates the same.
To fix, add global continue_game in the method definition.
below is code that will break out of the loop. to test I created a datas.txt file with one word and with the current logic, you have to type the word in that order for the str_found_letters != chosen_word to hit the else condition
import re
import random
folder = open("datas.txt","r")
data = folder.read()
word_list = re.sub("[^\w]"," ", data).split()
chosen_word = random.choice(word_list)
found_letters = []
continue_game = True
masked_word = []
for letter in chosen_word:
masked_word.append("*")
def guess_letter():
global continue_game, chosen_word, found_letters, masked_word
letter_player = raw_input('enter a letter pls: ')
for letter in range(0,len(chosen_word)):
if letter_player == chosen_word[letter]:
found_letters.append(letter_player)
masked_word[letter] = letter_player
else:
masked_word[letter] = '*'
print(masked_word[letter])
str_found_letters = ''.join(found_letters)
print(str_found_letters)
if(str_found_letters != chosen_word):
continue_game = True
else:
continue_game = False
while continue_game:
guess_letter()

How can you hide letters in a word with an asterisk?

I am currently working on a hangman project. I am having problems with hiding characters in words with asterisks - like, "word" would be ****, then when the player makes a guess and it's correct, the letter would appear where it should be, instead of the asterisk, like if you guessed 'o', *o**. How can I do this?
This is my current code.
import random
start = 1
class hangman():
def __init__(self):
self.__word = word
self.__incorrectg = none
word = random.choice(open(input("please type the file you wish to open ")).readlines())
print (word)
lettercount = len([ltr for ltr in word if ltr.isalpha()])
print (lettercount)

If you stored the players guesses in a list for instance:
used_letters = [] # and append guesses to this, both right and wrong
so as soon as the user inputs a guess, you append it to used_letters.
with open(filepath) as f: # this might be a better way to open the file
word = random.choice(f.readlines()) # after this statement the file is auto closed, and frees up the memory
and you have the actual word stored as a list as in:
word = list(word) #made into a list of the letters in the word
then you could do something like:
guessed_string = ''.join(letter if letter in used_letters else '*' for letter in the_word)
EDIT:
#prints out the starred string. i.e. unguessed letters are '*' and guessed letters that appear in the word appear as normal letters.
print guessed_string
let me know if this works for you.
Example:
if word = 'arbitrary'
word = list(word) gives:
['a','r','b','i','t','r','a','r','y']
if the user has so far guessed:
used_letters = ['a', 'b', 'e', 'r']
then
guessed_string = ''.join(letter if letter in used_letters else '*' for letter in word)
print guessed_string
will give:
'arb**rar*'

value="C9T1573518"
new_value=value[0:3]
new_value+="".join(value[l].replace(value[l],"*") for l in range(3,len(value),1))
print(
new_value
)

#!/usr/bin
def password(word):
class __password:
def __repr__(self):
return "*" * len(word)
return __password()
word = password("Mypassword123")
print word
Took a while but I was finally able to get it:
#!/usr/bin
def password(word):
external_repr = set()
class __password:
def __repr__(self):
return ''.join(word[i] if word[i] in external_repr else '*' for i in xrange(len(word)))
def __eq__(self, somestring):
return word == somestring
def guess(self, letter):
external_repr.add(letter[0])
def encrypt(self):
return "*" * len(word)
return __password()
word = password("Mypassword123")
if word == "Mypassword123": print "Passwords match!"
print "The encrypted password is", word.encrypt()
word.guess('s')
print "After your guess, the word is now", word

How to match words in a list with user input in python?

I am working on program which takes user input and replaces the words in a list with 'x'.
eg is the word is sucks and user input is "this word is sucks". the output should be "this word is xxxxx.
this is what i have so far. how can i access the elements in the list and match with the user input?
def main():
message = []
words = ['drat','crap','sucks']
counter = 0
userInput = str(input("Enter The Sentense: "))
truncatedInput = userInput[:140]
sentence = truncatedInput.split()
for i in range(len(sentence)):

def main():
final_message = []
words = ['drat','crap','sucks']
counter = 0
userInput = input("Enter The Sentense: ") # use raw_input if you're using python2.X
truncatedInput = userInput[:140]
sentence = truncatedInput.split()
for word in sentence:
if word in words:
word = 'x' * len(word)
final_message.append(word)
print ' '.join(final_message)